api_client-data.test.js ➔ describe(ꞌdata apiꞌ) - Code Metrics - Inspection of "Btccomapi converter" - blocktrail/blocktrail-sdk-nodejs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#99)

by Ruben de

created 2018-03-07 11:19 UTC

api_client-data.test.js ➔ describe(ꞌdata apiꞌ) B

↳ Parent: test/api_client-data.test.js

Complexity

Conditions	1
Paths	1

Size

Total Lines

185

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
cc	1
c	3
b	0
f	0
nc	1
dl	0
loc	185
rs	8.2857
nop	0

13 Functions

Rating	Name	Size	Complexity
B	api_client-data.test.js ➔ ... ➔ it(ꞌtest addressꞌ)	26	1
A	api_client-data.test.js ➔ ... ➔ it(ꞌtest addressUnconfirmedTransactionsꞌ)	10	1
A	api_client-data.test.js ➔ ... ➔ it(ꞌtest addressTransactionsꞌ)	22	1
A	api_client-data.test.js ➔ ... ➔ it(ꞌtest addressUnspentOutputsꞌ)	10	1
A	api_client-data.test.js ➔ ... ➔ it(ꞌtest allBlocksꞌ)	11	1
B	api_client-data.test.js ➔ ... ➔ it(ꞌtest batch transactionsꞌ)	30	1
A	api_client-data.test.js ➔ ... ➔ it(ꞌtest blockLatestꞌ)	8	1
A	api_client-data.test.js ➔ ... ➔ it(ꞌtest block by heightꞌ)	9	1
A	api_client-data.test.js ➔ ... ➔ it(ꞌtest blockTransactionsꞌ)	10	1
A	api_client-data.test.js ➔ ... ➔ it(ꞌtest coinbase transactionꞌ)	9	1
A	api_client-data.test.js ➔ ... ➔ it(ꞌtest tx 95740451ac22f63c42c0d1b17392a0bf02983176d6de8dd05d6f06944d93e615ꞌ)	14	2
A	api_client-data.test.js ➔ ... ➔ it(ꞌtest verifyAddressꞌ)	8	1
A	api_client-data.test.js ➔ ... ➔ it(ꞌtest block by hashꞌ)	16	1

How to fix Long Method

/* jshint -W101, -W098 */
var blocktrail = require('../');
var assert = require('assert');
var crypto = require('crypto');

/**
 * @type APIClient
 */
var client = blocktrail.BlocktrailSDK({
    apiKey: process.env.BLOCKTRAIL_SDK_APIKEY || "EXAMPLE_BLOCKTRAIL_SDK_NODEJS_APIKEY",
    apiSecret: process.env.BLOCKTRAIL_SDK_APISECRET || "EXAMPLE_BLOCKTRAIL_SDK_NODEJS_APISECRET",
    btccom: typeof process.env.BLOCKTRAIL_SDK_BTCCOM !== "undefined" ? JSON.parse(process.env.BLOCKTRAIL_SDK_BTCCOM) : true
});

var cleanTxin = function(txin) {
    delete txin.output_confirmed;
    delete txin.multisig;
    delete txin.multisig_addresses;
};

var cleanTxout = function(txout) {
    if (txout.type === 'witnessscripthash') {
        txout.type = 'unknown';
        txout.address = null;
    }

    if (!txout.spent_hash) {
        txout.spent_index = -1;
    }

    delete txout.multisig;
    delete txout.multisig_addresses;
};

var cleanTx = function(tx) {
    [
        'block_hash', // @TODO
        'confirmations', 'estimated_change', 'estimated_change_address', 'estimated_value',
        'is_coinbase', 'time', 'version', 'weight', 'witness_hash', 'is_double_spend', 'is_sw_tx',
        'sigops', 'lock_time', 'contains_dust', 'double_spend_in', 'enough_fee', 'first_seen_at',
        'last_seen_at', 'high_priority', 'unconfirmed_inputs'
    ].forEach(function(prop) {
        delete tx[prop];
    });

    tx.inputs.forEach(function(txin) {
        cleanTxin(txin);
    });

    tx.outputs.forEach(function(txout) {
        cleanTxout(txout);
    });
};

var cleanBlock = function(block) {
    delete block.confirmations;
    delete block.is_sw_block;
    delete block.created_at;
    delete block.bits;
    delete block.reward_block;
    delete block.reward_fees;
    delete block.weight;
    delete block.value;
};

describe('data api', function() {
    it('test address', function(cb) {
        client.address("3EU8LRmo5PgcSwnkn6Msbqc8BKNoQ7Xief", function(err, address) {
            assert.ifError(err);
            assert.ok(address['address']);
            assert.equal(address['address'], '3EU8LRmo5PgcSwnkn6Msbqc8BKNoQ7Xief');

            // trim off deprecated fields
            delete address.category;
            delete address.tag;
            delete address.first_seen;
            delete address.last_seen;
            delete address.total_transactions_in;
            delete address.total_transactions_out;
            delete address.unconfirmed_utxos;
            // trim off new fields
            delete address.first_tx;
            delete address.last_tx;

            assert.deepEqual(
                address,
                require('./test_data/address.3EU8LRmo5PgcSwnkn6Msbqc8BKNoQ7Xief')
            );

            cb();
        });
    });
    it('test addressTransactions', function(cb) {
        client.addressTransactions("3EU8LRmo5PgcSwnkn6Msbqc8BKNoQ7Xief", {limit: 20}, function(err, address_txs) {
            assert.ifError(err);

            assert.ok(address_txs['data']);
            assert.ok(address_txs['total']);

            var expected = require('./test_data/addressTxs.3EU8LRmo5PgcSwnkn6Msbqc8BKNoQ7Xief');
            var expectedTxMap = {};
            expected.data.forEach(function(tx) {
                cleanTx(tx);
                expectedTxMap[tx.hash] = tx;
            });

            address_txs.data.forEach(function(tx) {
                cleanTx(tx);
                assert.deepEqual(tx, expectedTxMap[tx.hash]);
            });

            cb();
        });
    });
    it('test addressUnconfirmedTransactions', function(cb) {
        client.addressUnconfirmedTransactions("1dice8EMZmqKvrGE4Qc9bUFf9PX3xaYDp", {limit: 23}, function(err, address_txs) {
            assert.ifError(err);
            assert.ok('data' in address_txs);
            assert.ok('total' in address_txs);
            assert.ok(address_txs['total'] >= address_txs['data'].length);

            cb();
        });
    });
    it('test addressUnspentOutputs', function(cb) {
        client.addressUnspentOutputs("3EU8LRmo5PgcSwnkn6Msbqc8BKNoQ7Xief", {limit: 23}, function(err, address_utxo) {
            assert.ifError(err);
            assert.ok('data' in address_utxo);
            assert.ok('total' in address_utxo);
            assert.ok(address_utxo['total'] >= address_utxo['data'].length);

            cb();
        });
    });
    it('test verifyAddress', function(cb) {
        client.verifyAddress("16dwJmR4mX5RguGrocMfN9Q9FR2kZcLw2z", "HPMOHRgPSMKdXrU6AqQs/i9S7alOakkHsJiqLGmInt05Cxj6b/WhS7kJxbIQxKmDW08YKzoFnbVZIoTI2qofEzk=", function(err, result) {
            assert.ifError(err);
            assert.ok(result);

            cb();
        });
    });
    it('test block by hash', function(cb) {
        client.block("000000000000034a7dedef4a161fa058a2d67a173a90155f3a2fe6fc132e0ebf", function(err, block) {
            assert.ifError(err);
            assert.ok(block['hash']);
            assert.equal(block['hash'], '000000000000034a7dedef4a161fa058a2d67a173a90155f3a2fe6fc132e0ebf');

            var expected = require('./test_data/block.000000000000034a7dedef4a161fa058a2d67a173a90155f3a2fe6fc132e0ebf');

            cleanBlock(block);
            cleanBlock(expected);

            assert.deepEqual(block, expected);

            cb();
        });
    });
    it('test block by height', function(cb) {
        client.block(200000, function(err, block) {
            assert.ifError(err);
            assert.ok(block['hash']);
            assert.equal(block['hash'], '000000000000034a7dedef4a161fa058a2d67a173a90155f3a2fe6fc132e0ebf');

            cb();
        });
    });
    it('test blockTransactions', function(cb) {
        client.blockTransactions("000000000000034a7dedef4a161fa058a2d67a173a90155f3a2fe6fc132e0ebf", {limit: 23}, function(err, block_txs) {
            assert.ifError(err);
            assert.ok(block_txs['data']);
            assert.ok(block_txs['total']);
            assert.ok(block_txs['data'].length === 23);

            cb();
        });
    });
    it('test allBlocks', function(cb) {
        client.allBlocks({page: 2, limit: 23, sort_dir: 'asc'}, function(err, blocks) {
            assert.ifError(err);

            assert.ok(blocks['data']);
            assert.ok(blocks['total']);
            assert.ok(blocks['data'].length === 23);

            cb();
        });
    });
    it('test blockLatest', function(cb) {
        client.blockLatest(function(err, block) {
            assert.ifError(err);
            assert.ok(block['hash']);

            cb();
        });
    });
    it('test coinbase transaction', function(cb) {
        client.transaction("0e3e2357e806b6cdb1f70b54c3a3a17b6714ee1f0e68bebb44a74b1efd512098", function(err, tx) {
            assert.ifError(err);
            assert.equal(tx['hash'], "0e3e2357e806b6cdb1f70b54c3a3a17b6714ee1f0e68bebb44a74b1efd512098");
            assert.equal(tx['enough_fee'], null);

            cb();
        });
    });
    it('test tx 95740451ac22f63c42c0d1b17392a0bf02983176d6de8dd05d6f06944d93e615', function(cb) {
        client.transaction("95740451ac22f63c42c0d1b17392a0bf02983176d6de8dd05d6f06944d93e615", function(err, tx) {
            assert.ifError(err);
            assert.equal(tx['hash'], "95740451ac22f63c42c0d1b17392a0bf02983176d6de8dd05d6f06944d93e615");

            var expected = require('./test_data/tx.95740451ac22f63c42c0d1b17392a0bf02983176d6de8dd05d6f06944d93e615');
            cleanTx(expected);
            cleanTx(tx);

            assert.deepEqual(tx, expected);

            cb();
        });
    });
    it('test batch transactions', function(cb) {
        client.transactions([
            "c791b82ed9af681b73eadb7a05b67294c1c3003e52d01e03775bfb79d4ac58d1",
            "0e3e2357e806b6cdb1f70b54c3a3a17b6714ee1f0e68bebb44a74b1efd512098",
            "4bbe6feeb50e47e2de5ef6a9d7378363823611dd07d4a5ea1799da9ae6a21665",
            "6c0d3156621051a86b8af3f23dfe211e8a17a01bffe3c2b24cbee65139873c6a",
            "356210d6b8143e23d0cf4d0dae0ac686015a13fe3b2b46b1cc43a71a36c73355",
            "a40d1eee0cec3d963d8df2870bd642bd3fd07163e864aeb90fa5efe9ea91c998",
            "1c7e3c9823baa9bb70b09ed666e8a6b3120b07f84429ed41f05d5504bd58f188",
            "1f0a168f0fceb6e48208b23ffb1ad528acfc11c30ab302d447743f2a0fc5fe80"
        ], function(err, txs) {
            assert.ifError(err);

            assert.equal(Object.keys(txs['data']).length, 8);

            var tx1 = txs['data']["c791b82ed9af681b73eadb7a05b67294c1c3003e52d01e03775bfb79d4ac58d1"];
            assert.equal(tx1['hash'], "c791b82ed9af681b73eadb7a05b67294c1c3003e52d01e03775bfb79d4ac58d1");
            assert.ok(tx1['confirmations']);

            var tx2 = txs['data']["0e3e2357e806b6cdb1f70b54c3a3a17b6714ee1f0e68bebb44a74b1efd512098"];
            assert.equal(tx2['hash'], "0e3e2357e806b6cdb1f70b54c3a3a17b6714ee1f0e68bebb44a74b1efd512098");

            var tx8 = txs['data']["1f0a168f0fceb6e48208b23ffb1ad528acfc11c30ab302d447743f2a0fc5fe80"];
            assert.equal(tx8['hash'], "1f0a168f0fceb6e48208b23ffb1ad528acfc11c30ab302d447743f2a0fc5fe80");

            assert.ok(!txs['data']['ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff']);

            cb();
        });
    });
});



1			/* jshint -W101, -W098 */
2			var blocktrail = require('../');
3			var assert = require('assert');
4			var crypto = require('crypto');
5
6			/**
7			* @type APIClient
8			*/
9			var client = blocktrail.BlocktrailSDK({
10			apiKey: process.env.BLOCKTRAIL_SDK_APIKEY \|\| "EXAMPLE_BLOCKTRAIL_SDK_NODEJS_APIKEY",
11			apiSecret: process.env.BLOCKTRAIL_SDK_APISECRET \|\| "EXAMPLE_BLOCKTRAIL_SDK_NODEJS_APISECRET",
12			btccom: typeof process.env.BLOCKTRAIL_SDK_BTCCOM !== "undefined" ? JSON.parse(process.env.BLOCKTRAIL_SDK_BTCCOM) : true
13			});
14
15			var cleanTxin = function(txin) {
16			delete txin.output_confirmed;
17			delete txin.multisig;
18			delete txin.multisig_addresses;
19			};
20
21			var cleanTxout = function(txout) {
22			if (txout.type === 'witnessscripthash') {
23			txout.type = 'unknown';
24			txout.address = null;
25			}
26
27			if (!txout.spent_hash) {
28			txout.spent_index = -1;
29			}
30
31			delete txout.multisig;
32			delete txout.multisig_addresses;
33			};
34
35			var cleanTx = function(tx) {
36			[
37			'block_hash', // @TODO
38			'confirmations', 'estimated_change', 'estimated_change_address', 'estimated_value',
39			'is_coinbase', 'time', 'version', 'weight', 'witness_hash', 'is_double_spend', 'is_sw_tx',
40			'sigops', 'lock_time', 'contains_dust', 'double_spend_in', 'enough_fee', 'first_seen_at',
41			'last_seen_at', 'high_priority', 'unconfirmed_inputs'
42			].forEach(function(prop) {
43			delete tx[prop];
44			});
45
46			tx.inputs.forEach(function(txin) {
47			cleanTxin(txin);
48			});
49
50			tx.outputs.forEach(function(txout) {
51			cleanTxout(txout);
52			});
53			};
54
55			var cleanBlock = function(block) {
56			delete block.confirmations;
57			delete block.is_sw_block;
58			delete block.created_at;
59			delete block.bits;
60			delete block.reward_block;
61			delete block.reward_fees;
62			delete block.weight;
63			delete block.value;
64			};
65
66			describe('data api', function() {
67			it('test address', function(cb) {
68			client.address("3EU8LRmo5PgcSwnkn6Msbqc8BKNoQ7Xief", function(err, address) {
69			assert.ifError(err);
70			assert.ok(address['address']);
71			assert.equal(address['address'], '3EU8LRmo5PgcSwnkn6Msbqc8BKNoQ7Xief');
72
73			// trim off deprecated fields
74			delete address.category;
75			delete address.tag;
76			delete address.first_seen;
77			delete address.last_seen;
78			delete address.total_transactions_in;
79			delete address.total_transactions_out;
80			delete address.unconfirmed_utxos;
81			// trim off new fields
82			delete address.first_tx;
83			delete address.last_tx;
84
85			assert.deepEqual(
86			address,
87			require('./test_data/address.3EU8LRmo5PgcSwnkn6Msbqc8BKNoQ7Xief')
88			);
89
90			cb();
91			});
92			});
93			it('test addressTransactions', function(cb) {
94			client.addressTransactions("3EU8LRmo5PgcSwnkn6Msbqc8BKNoQ7Xief", {limit: 20}, function(err, address_txs) {
95			assert.ifError(err);
96
97			assert.ok(address_txs['data']);
98			assert.ok(address_txs['total']);
99
100			var expected = require('./test_data/addressTxs.3EU8LRmo5PgcSwnkn6Msbqc8BKNoQ7Xief');
101			var expectedTxMap = {};
102			expected.data.forEach(function(tx) {
103			cleanTx(tx);
104			expectedTxMap[tx.hash] = tx;
105			});
106
107			address_txs.data.forEach(function(tx) {
108			cleanTx(tx);
109			assert.deepEqual(tx, expectedTxMap[tx.hash]);
110			});
111
112			cb();
113			});
114			});
115			it('test addressUnconfirmedTransactions', function(cb) {
116			client.addressUnconfirmedTransactions("1dice8EMZmqKvrGE4Qc9bUFf9PX3xaYDp", {limit: 23}, function(err, address_txs) {
117			assert.ifError(err);
118			assert.ok('data' in address_txs);
119			assert.ok('total' in address_txs);
120			assert.ok(address_txs['total'] >= address_txs['data'].length);
121
122			cb();
123			});
124			});
125			it('test addressUnspentOutputs', function(cb) {
126			client.addressUnspentOutputs("3EU8LRmo5PgcSwnkn6Msbqc8BKNoQ7Xief", {limit: 23}, function(err, address_utxo) {
127			assert.ifError(err);
128			assert.ok('data' in address_utxo);
129			assert.ok('total' in address_utxo);
130			assert.ok(address_utxo['total'] >= address_utxo['data'].length);
131
132			cb();
133			});
134			});
135			it('test verifyAddress', function(cb) {
136			client.verifyAddress("16dwJmR4mX5RguGrocMfN9Q9FR2kZcLw2z", "HPMOHRgPSMKdXrU6AqQs/i9S7alOakkHsJiqLGmInt05Cxj6b/WhS7kJxbIQxKmDW08YKzoFnbVZIoTI2qofEzk=", function(err, result) {
137			assert.ifError(err);
138			assert.ok(result);
139
140			cb();
141			});
142			});
143			it('test block by hash', function(cb) {
144			client.block("000000000000034a7dedef4a161fa058a2d67a173a90155f3a2fe6fc132e0ebf", function(err, block) {
145			assert.ifError(err);
146			assert.ok(block['hash']);
147			assert.equal(block['hash'], '000000000000034a7dedef4a161fa058a2d67a173a90155f3a2fe6fc132e0ebf');
148
149			var expected = require('./test_data/block.000000000000034a7dedef4a161fa058a2d67a173a90155f3a2fe6fc132e0ebf');
150
151			cleanBlock(block);
152			cleanBlock(expected);
153
154			assert.deepEqual(block, expected);
155
156			cb();
157			});
158			});
159			it('test block by height', function(cb) {
160			client.block(200000, function(err, block) {
161			assert.ifError(err);
162			assert.ok(block['hash']);
163			assert.equal(block['hash'], '000000000000034a7dedef4a161fa058a2d67a173a90155f3a2fe6fc132e0ebf');
164
165			cb();
166			});
167			});
168			it('test blockTransactions', function(cb) {
169			client.blockTransactions("000000000000034a7dedef4a161fa058a2d67a173a90155f3a2fe6fc132e0ebf", {limit: 23}, function(err, block_txs) {
170			assert.ifError(err);
171			assert.ok(block_txs['data']);
172			assert.ok(block_txs['total']);
173			assert.ok(block_txs['data'].length === 23);
174
175			cb();
176			});
177			});
178			it('test allBlocks', function(cb) {
179			client.allBlocks({page: 2, limit: 23, sort_dir: 'asc'}, function(err, blocks) {
180			assert.ifError(err);
181
182			assert.ok(blocks['data']);
183			assert.ok(blocks['total']);
184			assert.ok(blocks['data'].length === 23);
185
186			cb();
187			});
188			});
189			it('test blockLatest', function(cb) {
190			client.blockLatest(function(err, block) {
191			assert.ifError(err);
192			assert.ok(block['hash']);
193
194			cb();
195			});
196			});
197			it('test coinbase transaction', function(cb) {
198			client.transaction("0e3e2357e806b6cdb1f70b54c3a3a17b6714ee1f0e68bebb44a74b1efd512098", function(err, tx) {
199			assert.ifError(err);
200			assert.equal(tx['hash'], "0e3e2357e806b6cdb1f70b54c3a3a17b6714ee1f0e68bebb44a74b1efd512098");
201			assert.equal(tx['enough_fee'], null);
202
203			cb();
204			});
205			});
206			it('test tx 95740451ac22f63c42c0d1b17392a0bf02983176d6de8dd05d6f06944d93e615', function(cb) {
207			client.transaction("95740451ac22f63c42c0d1b17392a0bf02983176d6de8dd05d6f06944d93e615", function(err, tx) {
208			assert.ifError(err);
209			assert.equal(tx['hash'], "95740451ac22f63c42c0d1b17392a0bf02983176d6de8dd05d6f06944d93e615");
210
211			var expected = require('./test_data/tx.95740451ac22f63c42c0d1b17392a0bf02983176d6de8dd05d6f06944d93e615');
212			cleanTx(expected);
213			cleanTx(tx);
214
215			assert.deepEqual(tx, expected);
216
217			cb();
218			});
219			});
220			it('test batch transactions', function(cb) {
221			client.transactions([
222			"c791b82ed9af681b73eadb7a05b67294c1c3003e52d01e03775bfb79d4ac58d1",
223			"0e3e2357e806b6cdb1f70b54c3a3a17b6714ee1f0e68bebb44a74b1efd512098",
224			"4bbe6feeb50e47e2de5ef6a9d7378363823611dd07d4a5ea1799da9ae6a21665",
225			"6c0d3156621051a86b8af3f23dfe211e8a17a01bffe3c2b24cbee65139873c6a",
226			"356210d6b8143e23d0cf4d0dae0ac686015a13fe3b2b46b1cc43a71a36c73355",
227			"a40d1eee0cec3d963d8df2870bd642bd3fd07163e864aeb90fa5efe9ea91c998",
228			"1c7e3c9823baa9bb70b09ed666e8a6b3120b07f84429ed41f05d5504bd58f188",
229			"1f0a168f0fceb6e48208b23ffb1ad528acfc11c30ab302d447743f2a0fc5fe80"
230			], function(err, txs) {
231			assert.ifError(err);
232
233			assert.equal(Object.keys(txs['data']).length, 8);
234
235			var tx1 = txs['data']["c791b82ed9af681b73eadb7a05b67294c1c3003e52d01e03775bfb79d4ac58d1"];
236			assert.equal(tx1['hash'], "c791b82ed9af681b73eadb7a05b67294c1c3003e52d01e03775bfb79d4ac58d1");
237			assert.ok(tx1['confirmations']);
238
239			var tx2 = txs['data']["0e3e2357e806b6cdb1f70b54c3a3a17b6714ee1f0e68bebb44a74b1efd512098"];
240			assert.equal(tx2['hash'], "0e3e2357e806b6cdb1f70b54c3a3a17b6714ee1f0e68bebb44a74b1efd512098");
241
242			var tx8 = txs['data']["1f0a168f0fceb6e48208b23ffb1ad528acfc11c30ab302d447743f2a0fc5fe80"];
243			assert.equal(tx8['hash'], "1f0a168f0fceb6e48208b23ffb1ad528acfc11c30ab302d447743f2a0fc5fe80");
244
245			assert.ok(!txs['data']['ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff']);
246
247			cb();
248			});
249			});
250			});
251
252

blocktrail / blocktrail-sdk-nodejs

Pull Request — master (#99)

api_client-data.test.js ➔ describe(ꞌdata apiꞌ) B

Complexity

Size

Duplication

Importance

13 Functions

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like